Add find tag feature to FindCommand #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dominic-Khoo
requested review from
reidenong,
volleyballkickedme,
lim-jt,
itsnotsherm and
a team
itsnotsherm
approved these changes
Oct 22, 2024
| + "the specified keywords (case-insensitive) and displays them as a list with index numbers.\n" | ||
| + "Parameters: KEYWORD [MORE_KEYWORDS]...\n" | ||
| + "Example: " + COMMAND_WORD + " alice bob charlie"; | ||
| + "Example: " + COMMAND_WORD + " alice bob charlie (for names) OR find t/diabetic t/G6PD-Def"; |
There was a problem hiding this comment.
there might be a better way to display this usage message but small issue
| import seedu.address.commons.util.ToStringBuilder; | ||
| import seedu.address.logic.Messages; | ||
| import seedu.address.model.Model; | ||
| import seedu.address.model.person.NameContainsKeywordsPredicate; |
There was a problem hiding this comment.
side note I think predicates can have their own directory for organisation
There was a problem hiding this comment.
noted, will do in next iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality for users to filter patients based on medical conditions (labeled as tags) using FindCommand.
Users have to provide the appropriate prefix, e.g find t/diabetic to search for patients with the "diabetic" tag.